Skip to content

Avoid assertion failure on after(k) or older(k) where k < 1 or k >= 0x80000000UL #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sipa merged 1 commit into from
Sep 4, 2019
Merged

Avoid assertion failure on after(k) or older(k) where k < 1 or k >= 0x80000000UL #4

sipa merged 1 commit into from
Sep 4, 2019

Conversation

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Aug 27, 2019

Before:

$ ./miniscript <<< "after(0)"
miniscript: bitcoin/script/miniscript.h:366: miniscript::Type miniscript::Node<Key>::CalcType() const [with Key = std::__cxx11::basic_string<char>]: Assertion `k >= 1 && k < 0x80000000UL' failed.
Aborted
$ ./miniscript <<< "older(0)"
miniscript: bitcoin/script/miniscript.h:366: miniscript::Type miniscript::Node<Key>::CalcType() const [with Key = std::__cxx11::basic_string<char>]: Assertion `k >= 1 && k < 0x80000000UL' failed.
Aborted

After:

$ ./miniscript <<< "after(0)"
Failed to parse as policy or miniscript 'after(0)'
$ ./miniscript <<< "older(0)"
Failed to parse as policy or miniscript 'older(0)'

@practicalswift practicalswift mentioned this pull request Sep 4, 2019
Closed
@sipa
Copy link
Owner

sipa commented Sep 4, 2019

ACK!

@sipa sipa merged commit a900aec into sipa:master Sep 4, 2019
This was referenced Sep 7, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@practicalswift @sipa