Various improvements (mostly around random fuzzer) #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Owner
Author
|
Moved one commit from here to #105, where it belongs more. |
darosior
reviewed
Mar 1, 2022
Contributor
darosior
left a comment
darosior
left a comment
There was a problem hiding this comment.
Looks good, just not sure if we should modify the script given by the fuzzer ourselves in the last commit instead of making the fuzzer actually output this Script itself (by running with a larger -max_len or just seeding the corpus ourselves).
darosior
reviewed
Mar 6, 2022
darosior
approved these changes
Mar 22, 2022
sipa
added a commit
that referenced
this pull request
Apr 14, 2022
a9e8533 Add type-driven variant of ConsumeNode (Pieter Wuille) 869d0d9 Make NodeInfo/GenNode track desired types (Pieter Wuille) 657191b Simplify ConsumeNode a bit (Pieter Wuille) Pull request description: Builds on top of #104. This adds a second random node fuzzer, which uses type requirements to more efficiently explore the space of valid miniscripts. The other one is kept, as it is less complicated and thus easier to make sure it doesn't miss anything. ACKs for top commit: darosior: ACK a9e8533 Tree-SHA512: 95a54a31744a1b23ef7762a5b049a0dcd46471facb351a130645741919e4a2125bdd6e21b73b075ad453f0c6e19175b0adaae1c79a2bf7e18b129f3d7413582c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.