forked from bitcoin/bitcoin
-
Notifications
You must be signed in to change notification settings - Fork 22
Contrib: Introduce script to tag compiled binaries for convenience (py) #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faf671b [wallet] Clarify rpc help message with regard to rounding (MarcoFalke)
30cdace [Wallet] Transaction View: LastMonth calculation fixed (crowning-)
It is unneeded after the last toolchain update, and missing from Trusty.
3503a78 release: remove libc6 dependency from the osx signing descriptor (Cory Fields)
fa989fb [qt] coincontrol workaround is still needed in qt5.4 (fixed in qt5.5) (MarcoFalke)
c0cf48d c++11: add scoped enum fallbacks to CPPFLAGS rather than defining them locally (Cory Fields)
4d10d2e Eliminate race condition in mempool_packages test (Suhas Daftuar)
bd34174 Update license year range to 2016 (Prayag Verma)
9d263bd Typo fixes in comments (Chris Wheeler)
0331aa3 Fixing typos on security-check.py and torcontrol.cpp (calebogden)
7777994 [qa] Fix pyton syntax in rpc tests (MarcoFalke)
fa1cb1a [qa] Test walletpassphrase timeout (MarcoFalke)
These are changes I needed to get gitian building to work with Debian 8.2, which is the version we tell to use. - Set up NAT, so that container can access network beyond host - Remove explicit cgroup setup - these are mounted automatically now
64360f1 Make max tip age an option instead of chainparam (Wladimir J. van der Laan)
…#7189. 3d19193 Remove spurious dollar sign. Fixes bitcoin#7189. (Chris Moore)
…ion for curl fa7a5c5 [depends] builders: No need to set -L and --location for curl (MarcoFalke)
…ements [updated] 8c5a5fb Improving wording related to Boost library requirements [updated] (Jonathan Cross)
…llet ca8fb59 wallet: Warn on unexpected EOF while salvaging wallet (Wladimir J. van der Laan)
Superseded by 4bdad99
…for depends) 5c70a6d Bugfix: gitian: Add curl to packages (now needed for depends) (Luke Dashjr)
fafe446 [depends] Delete unused patches (MarcoFalke)
2e23066 Delete outdated test-patches reference (lewuathe)
fa1b80d [travis] Only run check-doc.py once (MarcoFalke)
…ug window 5ecfa36 Remove openssl info from init/log and from Qt debug window (Jonas Schnelli)
…mpool 5a2b1c0 Don't resend wallet txs that aren't in our own mempool (Alex Morcos)
fa5f193 [travis] Exit early when check-doc.py fails (MarcoFalke)
086da92 Add tags to mempool's mapTx indices (Suhas Daftuar)
Adds feature from issue bitcoin#7484 modifies the ctrl-c binding to copy full transaction details in transaction view. Added translation
b51ed40 QT: Add 'copy full transaction details' option (Eric Shaw)
7d2f84c remove unused NOBLKS_VERSION_{START,END} constants (Pavel Vasin)
…etaddr on outbound c… 9988554 No "Unknown command" for getaddr command. (R E Broadley)
Author
|
Sorry, wrong opened tab... |
sipa
pushed a commit
that referenced
this pull request
Oct 1, 2021
…during shutdown 451ca24 qt, refactor: Drop intermediate BitcoinApplication::shutdownResult slot (Hennadii Stepanov) f3a17bb qt: Do not exit and re-enter main event loop during shutdown (Hennadii Stepanov) b4e0d2c qt, refactor: Allocate SendConfirmationDialog instances on heap (Hennadii Stepanov) 332dea2 qt, refactor: Keep HelpMessageDialog in the main event loop (Hennadii Stepanov) c8bae37 qt, refactor: Keep PSBTOperationsDialog in the main event loop (Hennadii Stepanov) 7fa91e8 qt, refactor: Keep AskPassphraseDialog in the main event loop (Hennadii Stepanov) 6f6fde3 qt, refactor: Keep EditAddressDialog in the main event loop (Hennadii Stepanov) 59f7ba4 qt, refactor: Keep CoinControlDialog in the main event loop (Hennadii Stepanov) 7830cd0 qt, refactor: Keep OptionsDialog in the main event loop (Hennadii Stepanov) 13f6188 qt: Add GUIUtil::ShowModalDialogAndDeleteOnClose (Hennadii Stepanov) Pull request description: On master (1ef34ee) during shutdown `QApplication` exits the main event loop, then re-enter again. This PR streamlines shutdown process by removing the need to interrupt the main event loop, that is required for #59. Also, blocking [`QDialog::exec()`](https://doc.qt.io/qt-5/qdialog.html#exec) calls are replaced with safer [`QDialog::show()`](https://doc.qt.io/qt-5/qwidget.html#show), except for `SendConfirmationDialog` as that change is not trivial (marked as TODO). The [`QDialog::open()`](https://doc.qt.io/qt-5/qdialog.html#open) was not used because the actual modality mode (application modal or window modal) of a dialog depends on whether it has a parent. This PR does not change behavior, and all touched dialogs are still application modal. As a follow up, a design research could suggest to make some dialogs window modal. NOTE for reviewers: quitting app while a dialog is open (e.g., via systray icon menu) must work fine. ACKs for top commit: laanwj: Code review and lighly tested ACK 451ca24 promag: ACK 451ca24, just changed signal to `quitRequested`. Tree-SHA512: ef01ab6ed803b202e776019a4e1f592e816f7bc786e00574b25a0bf16be2374ddf9db21f0a26da08700df7ef0ab9e879550df46dcfe3b6d940f5ed02ca5f8447
sipa
pushed a commit
that referenced
this pull request
Aug 7, 2025
efb8ea04e4 Merge bitcoin-core/crc32c-subtree#8: Sync to upstream 4a7a05c48d Merge remote-tracking branch 'google/main' into bitcoin-fork 21fc8ef304 Fix typo (#59) 89f69843a1 Fix misspelled "Proccess" in comment 02e65f4fd3 Bump deps (#56) b9d6e825a1 Fix Windows CI build. (#54) bbbb93ab5d Switch CI to GitHub Actions (#55) d46cd17d70 Add clangd cache directory to .gitignore. git-subtree-dir: src/crc32c git-subtree-split: efb8ea04e4a5b6a18dc4bc1908fd1cb2dcefb585
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I felt I needed to incorporate something like this to my workflow.
If it is not useful for bitcoin, I'm happy to propose it on elements, freicoin or just keep it to myself.
Still putting it here just in case.
Example usage (with the appropriate bitcoin/.git/config):