Tweak to "Testchain: Don't check the genesis block" #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Oh, this also allows the removal of the commit "Genesis block disk query fix" |
Owner
|
Merging. |
sipa
pushed a commit
that referenced
this pull request
Oct 28, 2020
6954156 qt: Fix visual quality of text in QR image (Hennadii Stepanov) 8071c75 qt, refactor: Limit scope of QPainter object (Hennadii Stepanov) Pull request description: Master (197450f):  This PR (6954156): - macOS 10.15.6  - Linux Mint 20  Fix #54 Fix bitcoin#19103 --- The first commit is easy to review with [`git diff --word-diff`](bitcoin-core/gui@8071c75?w=1). ACKs for top commit: jonasschnelli: Tested ACK 6954156 - tested on macOS 10.15. Fixes the problem. Tree-SHA512: 6ecb3397d2a5094c5f00ee05fc09520751568404e000a8691b6de7e57f38c2d5da628694e5e45a2b4cc302a846bbc00014c40820233eb026d3ebd4f68c2c9913
sipa
pushed a commit
that referenced
this pull request
Aug 7, 2025
efb8ea04e4 Merge bitcoin-core/crc32c-subtree#8: Sync to upstream 4a7a05c48d Merge remote-tracking branch 'google/main' into bitcoin-fork 21fc8ef304 Fix typo (#59) 89f69843a1 Fix misspelled "Proccess" in comment 02e65f4fd3 Bump deps (#56) b9d6e825a1 Fix Windows CI build. (#54) bbbb93ab5d Switch CI to GitHub Actions (#55) d46cd17d70 Add clangd cache directory to .gitignore. git-subtree-dir: src/crc32c git-subtree-split: efb8ea04e4a5b6a18dc4bc1908fd1cb2dcefb585
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the risk of bikeshedding...squashing this into "Testchain: Don't check the genesis block" reduces the diff size reasonably.