secp256k1_context_set_{error,illegal}_callback: Restore default handler by passing NULL as function argument

luke-jr · luke-jr · commit c9d7c2a48425 · 2015-09-19T19:32:52.000Z
diff --git a/include/secp256k1.h b/include/secp256k1.h
@@ -179,14 +179,14 @@ void secp256k1_context_destroy(
  *  Args: ctx:  an existing context object (cannot be NULL)
  *  In:   fun:  a pointer to a function to call when an illegal argument is
  *              passed to the API, taking a message and an opaque pointer
- *              (cannot be NULL).
+ *              (NULL restores a default handler that calls abort).
  *        data: the opaque pointer to pass to fun above.
  */
 void secp256k1_context_set_illegal_callback(
     secp256k1_context_t* ctx,
     void (*fun)(const char* message, void* data),
     void* data
-) SECP256K1_ARG_NONNULL(1) SECP256K1_ARG_NONNULL(2);
+) SECP256K1_ARG_NONNULL(1);
 
 /** Set a callback function to be called when an internal consistency check
  *  fails. The default is crashing.
@@ -200,14 +200,15 @@ void secp256k1_context_set_illegal_callback(
  *
  *  Args: ctx:  an existing context object (cannot be NULL)
  *  In:   fun:  a pointer to a function to call when an interal error occurs,
- *              taking a message and an opaque pointer (cannot be NULL).
+ *              taking a message and an opaque pointer (NULL restores a default
+ *              handler that calls abort).
  *        data: the opaque pointer to pass to fun above.
  */
 void secp256k1_context_set_error_callback(
     secp256k1_context_t* ctx,
     void (*fun)(const char* message, void* data),
     void* data
-) SECP256K1_ARG_NONNULL(1) SECP256K1_ARG_NONNULL(2);
+) SECP256K1_ARG_NONNULL(1);
 
 /** Parse a variable-length public key into the pubkey object.
  *
diff --git a/src/secp256k1.c b/src/secp256k1.c
@@ -95,11 +95,15 @@ void secp256k1_context_destroy(secp256k1_context_t* ctx) {
 }
 
 void secp256k1_context_set_illegal_callback(secp256k1_context_t* ctx, void (*fun)(const char* message, void* data), void* data) {
+    if (!fun)
+        fun = default_illegal_callback_fn;
     ctx->illegal_callback.fn = fun;
     ctx->illegal_callback.data = data;
 }
 
 void secp256k1_context_set_error_callback(secp256k1_context_t* ctx, void (*fun)(const char* message, void* data), void* data) {
+    if (!fun)
+        fun = default_error_callback_fn;
     ctx->error_callback.fn = fun;
     ctx->error_callback.data = data;
 }

Original file line number	Diff line number	Diff line change
`@@ -95,11 +95,15 @@ void secp256k1_context_destroy(secp256k1_context_t* ctx) {`
`95`	`95`	`}`
`96`	`96`
`97`	`97`	`void secp256k1_context_set_illegal_callback(secp256k1_context_t* ctx, void (fun)(const char message, void* data), void* data) {`
	`98`	`+ if (!fun)`
	`99`	`+ fun = default_illegal_callback_fn;`
`98`	`100`	`ctx->illegal_callback.fn = fun;`
`99`	`101`	`ctx->illegal_callback.data = data;`
`100`	`102`	`}`
`101`	`103`
`102`	`104`	`void secp256k1_context_set_error_callback(secp256k1_context_t* ctx, void (fun)(const char message, void* data), void* data) {`
	`105`	`+ if (!fun)`
	`106`	`+ fun = default_error_callback_fn;`
`103`	`107`	`ctx->error_callback.fn = fun;`
`104`	`108`	`ctx->error_callback.data = data;`
`105`	`109`	`}`