Remove redundant secp256k1_fe_normalize from secp256k1_gej_add_ge_var.

gmaxwell · gmaxwell · commit 1c29f2eb497b · 2014-12-06T05:09:57.000-08:00
This was a missed optimization in the extraction of gej+ge from gej+gej.
diff --git a/src/group_impl.h b/src/group_impl.h
@@ -294,7 +294,7 @@ static void secp256k1_gej_add_ge_var(secp256k1_gej_t *r, const secp256k1_gej_t *
     }
     r->infinity = 0;
     secp256k1_fe_t z12; secp256k1_fe_sqr(&z12, &a->z);
-    secp256k1_fe_t u1 = a->x; secp256k1_fe_normalize(&u1);
+    secp256k1_fe_t u1 = a->x;
     secp256k1_fe_t u2; secp256k1_fe_mul(&u2, &b->x, &z12);
     secp256k1_fe_t s1 = a->y; secp256k1_fe_normalize(&s1);
     secp256k1_fe_t s2; secp256k1_fe_mul(&s2, &b->y, &z12); secp256k1_fe_mul(&s2, &s2, &a->z);

Original file line number	Diff line number	Diff line change
`@@ -294,7 +294,7 @@ static void secp256k1_gej_add_ge_var(secp256k1_gej_t r, const secp256k1_gej_t `
`294`	`294`	`}`
`295`	`295`	`r->infinity = 0;`
`296`	`296`	`secp256k1_fe_t z12; secp256k1_fe_sqr(&z12, &a->z);`
`297`		`- secp256k1_fe_t u1 = a->x; secp256k1_fe_normalize(&u1);`
	`297`	`+ secp256k1_fe_t u1 = a->x;`
`298`	`298`	`secp256k1_fe_t u2; secp256k1_fe_mul(&u2, &b->x, &z12);`
`299`	`299`	`secp256k1_fe_t s1 = a->y; secp256k1_fe_normalize(&s1);`
`300`	`300`	`secp256k1_fe_t s2; secp256k1_fe_mul(&s2, &b->y, &z12); secp256k1_fe_mul(&s2, &s2, &a->z);`