Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sinonjs/sinon
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.0.9
Choose a base ref
...
head repository: sinonjs/sinon
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.0.10
Choose a head ref
  • 9 commits
  • 24 files changed
  • 3 contributors

Commits on May 21, 2018

  1. Revert spied fakeTimers to original state

    When sandbox.useFakeTimers() is called, the original setTimeout and
    other methods are replaced with fake methods. When such fake method is
    spied it's replaced again with another fake. To make sure that
    sandbox.restore() reverts setTimeout and other methods to the original
    state these fakes should be restored in reverse order to make sure each
    fake is restored to its predecessor when calling fake.restore().
    ig-pj committed May 21, 2018
    Configuration menu
    Copy the full SHA
    8b6f8a8 View commit details
    Browse the repository at this point in the history
  2. Use fakeTimers in the default sandbox

    This is to allow restoring spied fakeTimers in default sandbox.
    ig-pj committed May 21, 2018
    Configuration menu
    Copy the full SHA
    6799e1c View commit details
    Browse the repository at this point in the history
  3. Add issue number

    ig-pj committed May 21, 2018
    Configuration menu
    Copy the full SHA
    d19a4c0 View commit details
    Browse the repository at this point in the history
  4. Cache reverse function

    ig-pj committed May 21, 2018
    Configuration menu
    Copy the full SHA
    087bc1c View commit details
    Browse the repository at this point in the history

Commits on May 24, 2018

  1. Configuration menu
    Copy the full SHA
    033aa60 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    86b930c View commit details
    Browse the repository at this point in the history
  3. Merge pull request #1802 from ifrost/feature/restore-default-sandbox-…

    …fake-timers
    
    Fix  #1801: spied fakeTimers are not restored correctly
    
    closes #1780
    fatso83 authored May 24, 2018
    Configuration menu
    Copy the full SHA
    5ca48d3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    928379c View commit details
    Browse the repository at this point in the history
  5. 5.0.10

    fatso83 committed May 24, 2018
    Configuration menu
    Copy the full SHA
    41d0dcb View commit details
    Browse the repository at this point in the history
Loading