Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sinonjs/sinon
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.4.9
Choose a base ref
...
head repository: sinonjs/sinon
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.4.10
Choose a head ref
  • 11 commits
  • 67 files changed
  • 5 contributors

Commits on Mar 15, 2018

  1. test for combining onCall + yields + returns 

    Currently returns doesn't work with that combination
See issue #1736
    @nfriedly
    nfriedly committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    6fd78e1 View commit details
    Browse the repository at this point in the history

  2. Allow chained behaviors with a .onCall(#) 

    e.g. this code:

stub.onCall(0).yields(x).returns(y)

will once again both call the callback with x and return y.

This feature was present in v1.17.7, but lost somewhere between there and v4.4.5

Fixes #1736
    @nfriedly
    nfriedly committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    1414afb View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2018

  1. Add release documentation for v4.4.9

    @mroderick
    mroderick committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    f547ef8 View commit details
    Browse the repository at this point in the history

  2. Update docs/changelog.md and set new release id in docs/_config.yml

    @mroderick
    mroderick committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    48b9262 View commit details
    Browse the repository at this point in the history

  3. fix extra space typo

    @bleakley @mroderick
    bleakley authored and mroderick committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    f2696bd View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2018

  1. Merge pull request #1738 from nfriedly/issue-1736 

    Fix onCall(#) with chained behaviors
    @fatso83
    fatso83 authored Mar 28, 2018
    Configuration menu
    Copy the full SHA
    cee8156 View commit details
    Browse the repository at this point in the history

  2. Update docs of stub.throws 

    Docs and tests misleadingly suggested that the string parameters would
create an error of that type. This PR remedies that and makes clearer
that the parameters sumply set the error name and/or message property.

Closes #922

Originally submitted as #1730
    @MichaelPaulukonis @fatso83
    MichaelPaulukonis authored and fatso83 committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    3d50435 View commit details
    Browse the repository at this point in the history

  3. Update documentation for older releases

    @fatso83
    fatso83 committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    1069f15 View commit details
    Browse the repository at this point in the history

  4. Merge customized version of pull request #1730

    @fatso83
    fatso83 committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    3d18f04 View commit details
    Browse the repository at this point in the history

  5. Update History.md and AUTHORS for new release

    @fatso83
    fatso83 committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    d333180 View commit details
    Browse the repository at this point in the history

  6. 4.4.10

    @fatso83
    fatso83 committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    4ba4de7 View commit details
    Browse the repository at this point in the history
Loading