Allow stubbing getters and setters for function properties

lucasfcosta · lucasfcosta · commit 5bbfa515f393 · 2017-03-11T13:33:15.000-03:00
diff --git a/lib/sinon/stub.js b/lib/sinon/stub.js
@@ -41,14 +41,15 @@ function stub(object, property, descriptor) {
         return stub.create();
     }
 
+    var s = stub.create(arity);
+    s.rootObj = object;
+    s.propName = property;
+
     if (isStubbingNonFuncProperty) {
-        var s = stub.create();
-        s.rootObj = object;
-        s.propName = property;
         return s;
     }
 
-    return wrapMethod(object, property, stub.create(arity));
+    return wrapMethod(object, property, s);
 }
 
 stub.createStubInstance = function (constructor) {
diff --git a/test/stub-test.js b/test/stub-test.js
@@ -2295,6 +2295,20 @@ describe("stub", function () {
             assert.equals(myObj.prop, "bar");
         });
 
+        it("allows users to stub getter functions for functions", function () {
+            var myObj = {
+                prop: function propGetter() {
+                    return "foo";
+                }
+            };
+
+            createStub(myObj, "prop").get(function () {
+                return "bar";
+            });
+
+            assert.equals(myObj.prop, "bar");
+        });
+
         it("replaces old getters", function () {
             var myObj = {
                 get prop() {
@@ -2335,6 +2349,22 @@ describe("stub", function () {
             assert.equals(myObj.example, "bar");
         });
 
+        it("allows users to stub setter functions for functions", function () {
+            var myObj = {
+                prop: function propSetter() {
+                    return "foo";
+                }
+            };
+
+            createStub(myObj, "prop").set(function () {
+                myObj.example = "bar";
+            });
+
+            myObj.prop = "baz";
+
+            assert.equals(myObj.example, "bar");
+        });
+
         it("replaces old setters", function () {
             var myObj = { // eslint-disable-line accessor-pairs
                 set prop(val) {

Original file line number	Diff line number	Diff line change
`@@ -41,14 +41,15 @@ function stub(object, property, descriptor) {`
`41`	`41`	`return stub.create();`
`42`	`42`	`}`
`43`	`43`
	`44`	`+ var s = stub.create(arity);`
	`45`	`+ s.rootObj = object;`
	`46`	`+ s.propName = property;`
	`47`	`+`
`44`	`48`	`if (isStubbingNonFuncProperty) {`
`45`		`- var s = stub.create();`
`46`		`- s.rootObj = object;`
`47`		`- s.propName = property;`
`48`	`49`	`return s;`
`49`	`50`	`}`
`50`	`51`
`51`		`- return wrapMethod(object, property, stub.create(arity));`
	`52`	`+ return wrapMethod(object, property, s);`
`52`	`53`	`}`
`53`	`54`
`54`	`55`	`stub.createStubInstance = function (constructor) {`