without the code change, -Infinity is before Infinity in the array

So I checked - the spec actually says (if < 0 then = 0) but Infinity isn't explicitly treated - >Int32 numbers overflow and also get set to 0 but not explicitly.

Node on the other hand sets the value to 1 (and not 0) https://github.com/nodejs/node/blob/master/lib/internal/timers.js#L19 done in https://github.com/nodejs/node/blob/master/lib/internal/timers.js#L55

https://github.com/nodejs/node/blob/master/lib/internal/timers.js#L55

(I've never read much spec, so all questions are in good faith)

From the linked issue in Jest, I read it as point 8 in https://heycam.github.io/webidl/#abstract-opdef-converttoint (as it's a long, not EnforceRange), namely

If x is NaN, +0, +∞, or −∞, then return +0.

Yeah, exactly.

Oh, so we are in agreement. Cool! 😀

Do you think it's a bug in Node?

I suppose it's easy enough to emulate Node's behavior when we think we're faking timers in Node (as we have the addTimerReturnsObject variable)

Seeing as the tag failed, I'll be a bit cheeky and do @bnoordhuis

Do you happen to remember why timers are set to 1 and not 0?

Because that's what browsers did at the time. :-)

So glad you guys are looking into the sweaty details of this. Delegation is 👑 Hope you add some comments to the implementation to make code archaeology easier for future maintainers :)

I've opened an issue over at core about the bahvior - I think it's fine to be honest, it's not what the timers spec says but it's what Chrome and Node do basically nodejs/node#20596

FWIW, I'm fine setting it to 1. That's not observable from my test - the test is the order in which the callbacks gets invoked, not if the timeout is 0 or 1.

Node and Chrome behaves the way I expect for Infinity, -Infinity and NaN.

setTimeout(() => console.log(1), Infinity);
setTimeout(() => console.log(2), NaN);
setTimeout(() => console.log(3), -Infinity);
// => 1
// => 2
// => 3

While Lolex does 2, 3, 1. This PR fixes that, which is what matters to me 🙂