Ensure checks based Object.keys length pass for fake Dates (#513)

alexanderweiss · web-flow · commit 754d7856ec98 · 2024-10-28T12:04:55.000+01:00
diff --git a/src/fake-timers-src.js b/src/fake-timers-src.js
@@ -450,7 +450,10 @@ function withGlobal(_global) {
 
                 // ensures identity checks using the constructor prop still works
                 // this should have no other functional effect
-                this.constructor = NativeDate;
+                Object.defineProperty(this, "constructor", {
+                    value: NativeDate,
+                    enumerable: false,
+                });
             }
 
             static [Symbol.hasInstance](instance) {
diff --git a/test/fake-timers-test.js b/test/fake-timers-test.js
@@ -3212,6 +3212,12 @@ describe("FakeTimers", function () {
             assert.equals(date.constructor, realDate.constructor);
         });
 
+        it("creates Date objects where the constructor prop is not enumerable", function () {
+            const date = new this.clock.Date();
+
+            assert.equals(Object.keys(date).length, 0);
+        });
+
         it("creates Date objects representing clock time", function () {
             const date = new this.clock.Date();
 
