Skip to content

New Knowledge screen#279

Merged
nthykier merged 2 commits intomasterfrom
testing/knowledge_screen
Jun 11, 2020
Merged

New Knowledge screen#279
nthykier merged 2 commits intomasterfrom
testing/knowledge_screen

Conversation

@Xenega
Copy link
Member

@Xenega Xenega commented Jun 7, 2020

Fix #270.

knowledge_screen

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2020 •
edited
Loading

Codecov Report

Merging #279 into master will decrease coverage by 0.09%.
The diff coverage is 8.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #279      +/-   ##
==========================================
- Coverage   45.86%   45.77%   -0.10%     
==========================================
  Files          44       44              
  Lines        6942     6963      +21     
==========================================
+ Hits         3184     3187       +3     
- Misses       3758     3776      +18
Impacted Files Coverage Δ
singularity/code/graphics/button.py 26.57% <8.57%> (-1.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9d136a...570a821. Read the comment docs.

@Xenega Xenega force-pushed the testing/knowledge_screen branch from ffc2859 to d98807c Compare June 7, 2020 18:22
nthykier
nthykier reviewed Jun 7, 2020
View reviewed changes
Copy link
Member

@nthykier nthykier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me a first glance (only have a minor style remark that I can live with).

@gunchleoc: Does this branch solve the issue you were experiencing?

@Xenega Xenega force-pushed the testing/knowledge_screen branch from d98807c to 570a821 Compare June 7, 2020 22:01
@gunchleoc
Copy link
Contributor

gunchleoc commented Jun 8, 2020

Yes, it solves the issue for me :)

BTW there is anther bug on the knowledge screen: When you switch categories, the selected table index is the one from the previous category instead of selecting the first item. From a user perspective, the ideal solution would be to select the first item when the category hasn't been selected before, and remember the selection for each category separately.

@nthykier nthykier mentioned this pull request Jun 11, 2020
Closed
@nthykier nthykier merged commit 4ef6c88 into master Jun 11, 2020
@nthykier nthykier deleted the testing/knowledge_screen branch June 27, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nthykier nthykier nthykier left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Truncated text on Knowledge screen

4 participants

@Xenega @codecov-commenter @gunchleoc @nthykier