Skip to content

Add separators to numbers on statistics screen#266

Merged
nthykier merged 1 commit intosingularity:masterfrom
gunchleoc:statistics-number-separators
May 27, 2020
Merged

Add separators to numbers on statistics screen#266
nthykier merged 1 commit intosingularity:masterfrom
gunchleoc:statistics-number-separators

Conversation

@gunchleoc
Copy link
Contributor

The numbers can get very long during the end game, so it's better to have thousand/million/billion separators.

@codecov-commenter
Copy link

Codecov Report

Merging #266 into master will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #266   +/-   ##
=======================================
  Coverage   45.90%   45.90%           
=======================================
  Files          44       44           
  Lines        6915     6916    +1     
=======================================
+ Hits         3174     3175    +1     
  Misses       3741     3741           
Impacted Files Coverage Δ
singularity/code/stats.py 92.45% <50.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f9993a...7ab79e8. Read the comment docs.

@nthykier nthykier merged commit 9f38a77 into singularity:master May 27, 2020
@gunchleoc gunchleoc deleted the statistics-number-separators branch May 28, 2020 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants