Skip to content

Shift transdinemsional to bottom and separate Europe from other labels#261

Closed
gunchleoc wants to merge 2 commits intosingularity:masterfrom
gunchleoc:locations
Closed

Shift transdinemsional to bottom and separate Europe from other labels#261
gunchleoc wants to merge 2 commits intosingularity:masterfrom
gunchleoc:locations

Conversation

@gunchleoc
Copy link
Contributor

  1. Vertically separate Europe from N America and Asia labels
  2. Fix text truncation for "Moon" in gd locale
  3. Fix overlap of "Moon" and "Far Reaches" labels in gd locale

For 2. and 3., I had to move "Transdimensional" to the bottom of the screen. There is no other solution to this problem that I can see - I am open to other ideas :)

I have shifted the "Far Reaches" to the left after the screenshots for the new screens below were taken, to make the label fit the screen for the fr and pt locales.

Screenshot of "Moon" truncation:

locations_moon_truncation

Screenshot of "Moon" and "Far Reaches" overlap:

locations_far_reaches_overlap

New screens in gd and en:

locations-en
locations-gd

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2020

Codecov Report

Merging #261 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #261   +/-   ##
=======================================
  Coverage   45.90%   45.90%           
=======================================
  Files          44       44           
  Lines        6915     6915           
=======================================
  Hits         3174     3174           
  Misses       3741     3741           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f9993a...8b3d607. Read the comment docs.

@nthykier
Copy link
Member

@Xenega Do you have any recommendations for how to handle this? My only other suggestion is to reduce the font size for locations.

@gunchleoc
Copy link
Contributor Author

Another thing that would help was if locations had alignment parameters, so we could make the Moon button location left-aligned and Transdimensional right-aligned. It still won't fit without reducing the font size though. If the Far Reaches could shift its position according to the width of the other 2 labels, that would help further for supporting all locales, but that will be tricker to do.

@gunchleoc
Copy link
Contributor Author

Alternative proposal using smaller text is in #264

@gunchleoc
Copy link
Contributor Author

The alternative proposal has been merged, so I am deleting this one.

@gunchleoc gunchleoc closed this May 28, 2020
@gunchleoc gunchleoc deleted the locations branch May 28, 2020 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants