Skip to content

Add a button OK to change custom resolution.#242

Merged
Xenega merged 1 commit intomasterfrom
custom_res
Mar 19, 2020
Merged

Add a button OK to change custom resolution.#242
Xenega merged 1 commit intomasterfrom
custom_res

Conversation

@Xenega
Copy link
Member

@Xenega Xenega commented Mar 18, 2020

Solve #236.

@codecov-io
Copy link

codecov-io commented Mar 18, 2020

Codecov Report

Merging #242 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #242   +/-   ##
=======================================
  Coverage   45.88%   45.88%           
=======================================
  Files          44       44           
  Lines        6839     6839           
=======================================
  Hits         3138     3138           
  Misses       3701     3701           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7773971...5534c9b. Read the comment docs.

@Wuzzy2
Copy link
Contributor

Wuzzy2 commented Mar 18, 2020

The OK button is definitely more user-friendly (yeah, the “custom” button was confusing to me).

But the “hotker letter” of “&Custom” no longer works. Nothing happens when I press it. Maybe just drop it.

Also, if you have focus in one of the two number fields and hit ENTER, the game crashes. It doesn't matter if its a sane resolution like 1024×768 or an insane resolution like 3×3 or hello×world. :-)

@Xenega
Copy link
Member Author

Xenega commented Mar 18, 2020

the hotkey letter works for me
I solved the crash.

@Xenega Xenega merged commit 0537211 into master Mar 19, 2020
@nthykier nthykier deleted the custom_res branch June 27, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants