Skip to content

Make (some) text sizes configurable and reduce the default size#202

Merged
nthykier merged 1 commit intomasterfrom
different-font-sizes
Dec 19, 2019
Merged

Make (some) text sizes configurable and reduce the default size#202
nthykier merged 1 commit intomasterfrom
different-font-sizes

Conversation

@nthykier
Copy link
Member

I believe this will fix #200. With this patch, the story mode dialogs (among other) uses a consist font-size for me.

@evilmrhenry / @Xenega: If you have time, it would be great if you could review this change. Note I have deliberately skipped the Options widget to control text-sizes via the Options menu for now. If we merge this, I will file an issue to follow up on that later.

Copy link
Member

@evilmrhenry evilmrhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Implement configurable text sizes via the configuration file.  Option
dialog for this is currently omitted.

Closes: #200
Signed-off-by: Niels Thykier <[email protected]>
@nthykier nthykier force-pushed the different-font-sizes branch from e1352cc to c6e44fd Compare December 19, 2019 20:45
@codecov-io
Copy link

codecov-io commented Dec 19, 2019

Codecov Report

Merging #202 into master will decrease coverage by 0.06%.
The diff coverage is 26.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
- Coverage   45.68%   45.61%   -0.07%     
==========================================
  Files          41       41              
  Lines        5420     5439      +19     
==========================================
+ Hits         2476     2481       +5     
- Misses       2944     2958      +14
Impacted Files Coverage Δ
singularity/code/graphics/button.py 29.78% <0%> (-0.16%) ⬇️
singularity/__init__.py 7.4% <0%> (-0.36%) ⬇️
singularity/code/graphics/text.py 16.9% <100%> (+0.45%) ⬆️
singularity/code/graphics/g.py 38.75% <40%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7c6ea3...c6e44fd. Read the comment docs.

@nthykier nthykier merged commit 1d3d0f9 into master Dec 19, 2019
@nthykier nthykier deleted the different-font-sizes branch December 19, 2019 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Font resizing creates inconsistent appearance

3 participants