Make singularity run under python3 (in parallel with python2)#169
Conversation
nthykier
force-pushed
the
make-singularity-run-under-python3
branch
from
e228619 to
0e5ddbb
Compare
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
========================================
+ Coverage 30.84% 31% +0.16%
========================================
Files 35 36 +1
Lines 5032 5057 +25
========================================
+ Hits 1552 1568 +16
- Misses 3480 3489 +9
Continue to review full report at Codecov.
|
nthykier
force-pushed
the
make-singularity-run-under-python3
branch
2 times, most recently
from
8e852a2 to
e245c0f
Compare
|
For iter, I think we should use For pycompat, I don't see a avantage to add a underscore, just hide the real name (long instead of long_) Otherwise it's good. |
|
I can certainly do As for |
nthykier
force-pushed
the
make-singularity-run-under-python3
branch
4 times, most recently
from
e630421 to
8c6d7b7
Compare
Signed-off-by: Niels Thykier <[email protected]>
Signed-off-by: Niels Thykier <[email protected]>
This enables us to reference some things (mostly) by their python2 name while still supporting python3 in parallel. In time, this layer should be removed again when we stop supporting python2. Signed-off-by: Niels Thykier <[email protected]>
Signed-off-by: Niels Thykier <[email protected]>
Signed-off-by: Niels Thykier <[email protected]>
nthykier
force-pushed
the
make-singularity-run-under-python3
branch
from
8c6d7b7 to
1416caf
Compare
3 participants
These 3 commits are the only parts remaining to make singularity run under python3 (in parallel with python2). Note the emphasis on run because it needs testing to ensure that the game works the same in python2 and python3 (notably floating division might be an issue).