Support re-opening (some) messages in full via the log menu#128
Support re-opening (some) messages in full via the log menu#128nthykier merged 6 commits intosingularity:masterfrom
Conversation
|
For old savegames, just clear the old log dict. No need to perfectly handle case between major version. I prefer that you use only one id and one args list for each log message. You need to use named args. |
|
Xenega:
For old savegames, just clear the old log dict. No need to perfectly handle case between major version.
Ok.
I prefer that you use only one id and one args list for each log message. You need to use named args.
How would this work? To my knowledge, the short message and long message
have different IDs, so we will need both IDs (unless we re-key relevant
messages to use "%(msg_id)s_short" and "%(msg_id)s_full" for the short
and long message respectively).
Migrating to named arguments would be a fine solution to only having on
argument list (that works for both).
|
45cd2d0 to
c5c0045
Compare
Yes, we can build two key with one ID by adding a prefix. However, strings.dat will disappear in the future (because it's generics and duplicate with message.po). You can help me by either use message.po or create a new _str.dat file for log message. The rational between the two is message.po contains all interface strings and _str.dat file contains all strings related to game content. Orthewise, the idea is good. |
6787580 to
17da31e
Compare
The end goal is to support re-opening the full message of the event. However, this will come in a separate commit. Signed-off-by: Niels Thykier <[email protected]>
Signed-off-by: Niels Thykier <[email protected]>
Signed-off-by: Niels Thykier <[email protected]>
Signed-off-by: Niels Thykier <[email protected]>
Signed-off-by: Niels Thykier <[email protected]>
Signed-off-by: Niels Thykier <[email protected]>
17da31e to
0e1b482
Compare
|
I took a slightly different approach on this.
|
With this branch, it will be possible to re-read messages (in full) via the log menu by double clicking on the log line.
Known issues: