Conversation
|
I think a better approach will be to tackle #52 at the same time as #56 by defining a new format for the save game. I.e. choose a new serialization format (without code execution issues), convert the code to properly serialize to and deserialize from that format from the minimum required. That said, I can fully respect the desire for incremental improvements and I am fine with doing that while still using pickle. Some notes about the branch/code that are worth looking at before merging:
(Triggered a load followed by opening the base) |
|
@nthykier Basically, the response is time. Doing big changes is more time-consuming that just small incremental changes. Big changes have the drawback to be in conflicts with each other when they stall for too long. Feel free to try improve it if you can, but take care that I try to refactor the code and if you take this road, difficult rebase are expected. |
Do not save game data in savegame. Basically all types are removed from save.