Skip to content

move to setuptools#12

Closed
rardiol wants to merge 8 commits intosingularity:masterfrom
rardiol:setuptools
Closed

move to setuptools#12
rardiol wants to merge 8 commits intosingularity:masterfrom
rardiol:setuptools

Conversation

@rardiol
Copy link
Contributor

@rardiol rardiol commented Apr 24, 2016

Removed the old singularity.py and release submodules and moved to modern python packaging with setuptools. This is my first foray into python packaging, so please correct me if I did anything wrong.

Still should be done :


git submodule update --init release/windows

---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those "release steps" should still be present somewhere. They likely need updates, but are around 90% accurate and a useful checklist for releases.

@evilmrhenry
Copy link
Member

It's saying the branch has conflicts.

@MestreLion
Copy link
Member

Also, this is a very wide change, that accomplishes much more than just updating setup.py, so perhaps it's best if split into multiple commits? Specially the (welcome) code -> singularity dir renaming should be in its own commit.

@rardiol
Copy link
Contributor Author

rardiol commented May 27, 2016

Better now?

@evilmrhenry
Copy link
Member

I'm ok with it, but I want some other opinions.

@Quix0r
Copy link
Contributor

Quix0r commented Jul 11, 2016

MANIFEST.in misses a new-line character at the end of the file. Some editors may be confused or even crash if that line is not there. But else, it looks green to me. :-) Nice work.

@MestreLion
Copy link
Member

Care to rebase this patch so we can merge it?

@rardiol
Copy link
Contributor Author

rardiol commented Oct 15, 2017

rebased.

@Xenega Xenega added this to the 2.0 milestone Mar 31, 2018
@Xenega Xenega modified the milestones: 2.0, 1.0 Apr 21, 2018
@Xenega
Copy link
Member

Xenega commented Apr 22, 2018

Can you rebase it ?

@rardiol
Copy link
Contributor Author

rardiol commented May 5, 2018

I tried and it seemed like a nontrivial rebase with some code moves, and to be honest I did this so long ago I don't really remember the details of what I did, will finish the rebase later.

@Xenega
Copy link
Member

Xenega commented May 6, 2018

Yes, I am doing a lot of change. Thanks.

@Xenega
Copy link
Member

Xenega commented May 8, 2018

Since a lot of refactoring and change will be come next, if you can't do it in one time, I suggest you to wait I freeze before release.

@nthykier
Copy link
Member

Fixed in aba8ba6 based on commits by @rardiol.

@rardiol Thanks for your initial work on this task!

@nthykier nthykier closed this Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants