Conversation
|
|
||
| git submodule update --init release/windows | ||
|
|
||
| --- |
There was a problem hiding this comment.
Those "release steps" should still be present somewhere. They likely need updates, but are around 90% accurate and a useful checklist for releases.
|
It's saying the branch has conflicts. |
|
Also, this is a very wide change, that accomplishes much more than just updating |
|
Better now? |
|
I'm ok with it, but I want some other opinions. |
|
MANIFEST.in misses a new-line character at the end of the file. Some editors may be confused or even crash if that line is not there. But else, it looks green to me. :-) Nice work. |
|
Care to rebase this patch so we can merge it? |
|
rebased. |
|
Can you rebase it ? |
|
I tried and it seemed like a nontrivial rebase with some code moves, and to be honest I did this so long ago I don't really remember the details of what I did, will finish the rebase later. |
|
Yes, I am doing a lot of change. Thanks. |
|
Since a lot of refactoring and change will be come next, if you can't do it in one time, I suggest you to wait I freeze before release. |
Removed the old singularity.py and release submodules and moved to modern python packaging with setuptools. This is my first foray into python packaging, so please correct me if I did anything wrong.
Still should be done :