Add information-only golint to test runs#12
Merged
ascandella merged 1 commit intosingnet:masterfrom Jul 20, 2018
ascandella:vet-etc
Merged
Add information-only golint to test runs#12ascandella merged 1 commit intosingnet:masterfrom ascandella:vet-etc
ascandella merged 1 commit intosingnet:masterfrom
ascandella:vet-etc
Conversation
And start fixing some golints
erickearns
approved these changes
Jul 20, 2018
Contributor
erickearns
left a comment
erickearns
left a comment
There was a problem hiding this comment.
Presumably this enables the linting and addresses all errors?
Contributor
Author
|
It doesn't address all of them (there are about 30 left), I decided I'd fix those in a future diff to avoid massively conflicting with the other PRs I have open. Should be able to do it soon though (and then we can turn them from warnings into errors if we want). |
elmiringos
added a commit
to elmiringos/snet-daemon
that referenced
this pull request
Jan 16, 2025
* feat(training): add public model storage * test(training): add unit test for public model storage * feat(training/storage): add methods to update publicModelIds and pendingModelIds * test(training/storage): add TestPendingModelStorage_AddPendingModelId and TestPublicModelStorage_AddPublicModelId * feat(training/service): add public models handling in verifySignerHasAccessToTheModel, update createModelDetails * test(training): add usage newTrainingService instead of NewDaemonService
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And start fixing some golints