[python] fix incorrect typing of exported obs/var annotation matrices#4139
Merged
bkmartinjr merged 52 commits intomainfrom Jun 26, 2025
Merged
[python] fix incorrect typing of exported obs/var annotation matrices#4139bkmartinjr merged 52 commits intomainfrom
bkmartinjr merged 52 commits intomainfrom
Conversation
Member
Author
|
reverting to draft while I chase the SIGSEGV occurring in the MacOS tests |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4139 +/- ##
===========================================
+ Coverage 66.22% 89.47% +23.25%
===========================================
Files 161 60 -101
Lines 19860 7164 -12696
Branches 1235 0 -1235
===========================================
- Hits 13152 6410 -6742
+ Misses 6300 754 -5546
+ Partials 408 0 -408
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
added 20 commits
June 23, 2025 16:47
added 25 commits
June 24, 2025 16:44
jp-dark
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExperimentAxisQuery.to_anndata was always exporting obsm/varm matrices as
float32, regardless of their actual data type. This PR fixes the bug, and uses the underlying SOMA matrix data type to determine the matrix type to add to the anndata.Changes:
Fixes SOMA-322