[r] Handle empty matrices when creating SOMA from Seurat#990
Merged
mojaveazure merged 5 commits intomain-oldfrom Feb 23, 2023
Merged
[r] Handle empty matrices when creating SOMA from Seurat#990mojaveazure merged 5 commits intomain-oldfrom
mojaveazure merged 5 commits intomain-oldfrom
Conversation
Seurat allows empty matrices for counts and scale.data Empty matrices are defined as 0x0 or 1x1 with a value of NA Use SeuratObject::IsMatrixEmpty to determine empty matrices Skip writing empty matrices fixes TileDB-Inc/tiledbsc#92
johnkerl
approved these changes
Feb 23, 2023
Contributor
johnkerl
left a comment
johnkerl
left a comment
There was a problem hiding this comment.
LGTM! :)
But I defer to @aaronwolen for final approval
aaronwolen
approved these changes
Feb 23, 2023
Member
There was a problem hiding this comment.
Perfect! Thanks @mojaveazure!
Could you bump the version to 0.1.22.9002 and update NEWS.md?
Update changelog
…-data/TileDB-SOMA into ph/fix/seurat-empty-matrices
johnkerl
changed the title
52 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seurat allows empty matrices for
countsandscale.dataEmpty matrices are defined as 0x0 or 1x1 with a value of
NAUse
SeuratObject::IsMatrixEmptyto determine empty matricesSkip writing empty matrices
fixes Tiledb-Inc/tiledbsc#92