[c++/python/r] Move SOMADataFrame creation logic to C++#4421
Merged
XanthosXanthopoulos merged 19 commits intomainfrom Mar 2, 2026
Merged
[c++/python/r] Move SOMADataFrame creation logic to C++#4421XanthosXanthopoulos merged 19 commits intomainfrom
XanthosXanthopoulos merged 19 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4421 +/- ##
==========================================
- Coverage 86.02% 84.60% -1.42%
==========================================
Files 140 146 +6
Lines 21213 21502 +289
Branches 13 13
==========================================
- Hits 18248 18192 -56
- Misses 2965 3310 +345
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
XanthosXanthopoulos
force-pushed
the
xan/SOMA-864
branch
from
4a8a976 to
6bf7e05
Compare
XanthosXanthopoulos
changed the title
jp-dark
reviewed
Feb 27, 2026
Collaborator
jp-dark
left a comment
jp-dark
left a comment
There was a problem hiding this comment.
This PR is a huge improvement, but I do have a couple change requests.
Change requests:
- Unless there is a good reason to use
std::anyoverstd::variant, I think we should switch the domain types. - A couple nits around error messages.
- TBD: I still need to think through the right way to handle the inconsistencies between R and Python.
jp-dark
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: SOMA-864
Changes:
This PR moves the
DataFramecreation logic down to the common C++ layer and simplifies the R and Python implementations. Specificallyint32,int64anduint64columns are now narrower.Notes for Reviewer: