[python] Use arrow API to cast python tables before sending to C++#4359
Merged
[python] Use arrow API to cast python tables before sending to C++#4359
Conversation
Still needs the following: * fix schema names for GeometryDataFrame * test unsafe casting
Add test for dictionary casting from #4311 Co-authored-by: XanthosXanthopoulos <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4359 +/- ##
==========================================
+ Coverage 86.66% 89.04% +2.38%
==========================================
Files 139 62 -77
Lines 20931 7148 -13783
Branches 15 0 -15
==========================================
- Hits 18139 6365 -11774
+ Misses 2792 783 -2009
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
XanthosXanthopoulos
approved these changes
Jan 8, 2026
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-2.3 release-2.3
# Navigate to the new working tree
cd .worktrees/backport-release-2.3
# Create a new branch
git switch --create backport-4359-to-release-2.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a1f6a685b4752a7fd67961c2676438a6e625d371
# Push it to GitHub
git push --set-upstream origin backport-4359-to-release-2.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-2.3Then, create a pull request where the |
jp-dark
added a commit
that referenced
this pull request
Jan 12, 2026
…4359) * (WIP) Safe-cast pyarrow tables on write Still needs the following: * fix schema names for GeometryDataFrame * test unsafe casting * Fix casting for geometry dataframe outlines * Update history * Switch from deprecated `field_by_name` to `field` * Update error message and remove unneeded type declaration * Take tests from PR #4311 Add test for dictionary casting from #4311 Co-authored-by: XanthosXanthopoulos <[email protected]> * Add xfail to uncovered bug * Remove test that is checking for unsafe cast * Fix syntax for xfail --------- Co-authored-by: XanthosXanthopoulos <[email protected]> (cherry picked from commit a1f6a68)
jp-dark
added a commit
that referenced
this pull request
Jan 12, 2026
…4359) * (WIP) Safe-cast pyarrow tables on write Still needs the following: * fix schema names for GeometryDataFrame * test unsafe casting * Fix casting for geometry dataframe outlines * Update history * Switch from deprecated `field_by_name` to `field` * Update error message and remove unneeded type declaration * Take tests from PR #4311 Add test for dictionary casting from #4311 Co-authored-by: XanthosXanthopoulos <[email protected]> * Add xfail to uncovered bug * Remove test that is checking for unsafe cast * Fix syntax for xfail --------- Co-authored-by: XanthosXanthopoulos <[email protected]> (cherry picked from commit a1f6a68)
jp-dark
added a commit
that referenced
this pull request
Jan 13, 2026
…4359) (#4369) * (WIP) Safe-cast pyarrow tables on write Still needs the following: * fix schema names for GeometryDataFrame * test unsafe casting * Fix casting for geometry dataframe outlines * Update history * Switch from deprecated `field_by_name` to `field` * Update error message and remove unneeded type declaration * Take tests from PR #4311 Add test for dictionary casting from #4311 * Add xfail to uncovered bug * Remove test that is checking for unsafe cast * Fix syntax for xfail --------- (cherry picked from commit a1f6a68) Co-authored-by: XanthosXanthopoulos <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: Close SOMA-721
Changes:
Use pyarrow API to attempt to cast data before writing with the C++ API.