Adding shape validation for add_matrix_to_collection (#4258)#4329
Merged
jp-dark merged 1 commit intorelease-2.2from Dec 5, 2025
Merged
Adding shape validation for add_matrix_to_collection (#4258)#4329jp-dark merged 1 commit intorelease-2.2from
jp-dark merged 1 commit intorelease-2.2from
Conversation
* Adding shape validation for add_matrix_to_collection * Adding test for add_X_layer * Add context to the validation function * Schema validation optional default False * PR fixes * PR fixes vol 2 * Adding all versions in tests * Adding full docstrings * Add entry in HISTORY.md * Minor fixes for PR * Opening internal var dataframe in read mode when writing & text fix * PR fixes - timestamp, closed property * Add unit tests for previous versions * PR comments * PR comments * Add warning instead of log msg * Rebase with main * Final misc * Match argument to all tests (cherry picked from commit 2d91da6)
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-2.2 #4329 +/- ##
================================================
+ Coverage 76.13% 89.45% +13.31%
================================================
Files 233 61 -172
Lines 32559 7176 -25383
Branches 1236 0 -1236
================================================
- Hits 24789 6419 -18370
+ Misses 7346 757 -6589
+ Partials 424 0 -424
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport PR #4258