Supporting X missing/None for EAQ to_anndata#4250
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4250 +/- ##
===========================================
+ Coverage 76.02% 89.42% +13.40%
===========================================
Files 230 61 -169
Lines 32062 7131 -24931
Branches 1236 0 -1236
===========================================
- Hits 24374 6377 -17997
+ Misses 7267 754 -6513
+ Partials 421 0 -421
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
jp-dark
requested changes
Sep 26, 2025
Collaborator
jp-dark
left a comment
jp-dark
left a comment
There was a problem hiding this comment.
Looks good for the most part, but I have a couple change requests.
jp-dark
approved these changes
Sep 26, 2025
Collaborator
jp-dark
left a comment
jp-dark
left a comment
There was a problem hiding this comment.
One typo left in the HISTORY, but looks good otherwise.
Co-authored-by: Julia Dark <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context:
X_layer_nameis an optional parameter ontiledbsoma.io.to_anndata(), allowing users to create anndata objects whereXis empty.We should make exporting X optional for
tiledbsoma.ExperimentAxisQuery.to_anndata()as well, currently it's a required parameter.Changes:
tiledbsoma.io.to_anndataNotes for Reviewer:
soma_joinidcolumn that is being produced by the EAQ API but not from the soma.io.