[python] Remove deprecated python functions#4240
Conversation
- Remove deprecated function `tiledbsoma_build_index`, `io.append_obs`, `io.append_var`, `io.append_X`, and `io.create_from_matrix`. Remove the deprecated method `config_options_from_schema` from `SOMAArray`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4240 +/- ##
==========================================
- Coverage 76.12% 76.01% -0.12%
==========================================
Files 230 230
Lines 32117 32062 -55
Branches 1236 1236
==========================================
- Hits 24450 24372 -78
- Misses 7246 7269 +23
Partials 421 421
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
bkmartinjr
left a comment
bkmartinjr
left a comment
There was a problem hiding this comment.
the code changes look find. I don't know what to make of the HT failure based upon the logs. It seems most likely a test issue, or a latent bug unrelated to your changes.
My suggestion is to run this test locally with the --hypothesis-profile=expensive, which will test much more of the search space.
Approving, but I do think it would be a good idea to do the above in parallel
I think the failure might be related to the way hypothesis works with pytest However, I don't know why it would be causing a problem now when it hasn't before. |
3 participants
tiledbsoma_build_index,io.append_obs,io.append_var,io.append_X, andio.create_from_matrix.config_options_from_schemafromSOMAArray.