[python] return Arrow tables with dictionary of large_string, rather than string#4220
Merged
bkmartinjr merged 7 commits intomainfrom Sep 8, 2025
Merged
[python] return Arrow tables with dictionary of large_string, rather than string#4220bkmartinjr merged 7 commits intomainfrom
bkmartinjr merged 7 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4220 +/- ##
==========================================
+ Coverage 69.58% 75.39% +5.80%
==========================================
Files 169 229 +60
Lines 19072 30738 +11666
Branches 1233 1236 +3
==========================================
+ Hits 13272 23176 +9904
- Misses 5366 7140 +1774
+ Partials 434 422 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
added 5 commits
September 4, 2025 10:22
jp-dark
approved these changes
Sep 8, 2025
mojaveazure
approved these changes
Sep 8, 2025
Member
mojaveazure
left a comment
mojaveazure
left a comment
There was a problem hiding this comment.
LGTM; can you bump the R development version before merging?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on fix for SOMA-440, correctly setting the Arrow schema in tables returned by DataFrame.read.
For Python: the first fix, PR #4209, resolved the type as reported by the
schemaproperty. This PR finishes the job by returning Arrow tables with the correct schema.For R: revert the previous change, reverting to "small" string/binary types.
Note to reviewers: addition change in Python tests to further reduce memory on MacOS CI runners.