[python] add lock around SOMAGroup reification#4147
Merged
bkmartinjr merged 4 commits intomainfrom Jun 26, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4147 +/- ##
===========================================
+ Coverage 53.10% 89.46% +36.35%
===========================================
Files 101 60 -41
Lines 12702 7158 -5544
Branches 1238 0 -1238
===========================================
- Hits 6746 6404 -342
+ Misses 5548 754 -4794
+ Partials 408 0 -408
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
jp-dark
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SOMAGroup / Collection caches reified objects in getitem. This code lacked any concurrency protection, so objects requested concurrently would repeatedly load and overwrite the cache slot in the parent group.
This had a couple of problematic effects if a race to populate the cache occurs:
eq, but a side effect of the cache is that they are anyway)Changes: