[python] skip obs axis read-back when appending known unique observations to Experiment#4108
Merged
bkmartinjr merged 2 commits intomainfrom Jun 10, 2025
Merged
[python] skip obs axis read-back when appending known unique observations to Experiment#4108bkmartinjr merged 2 commits intomainfrom
bkmartinjr merged 2 commits intomainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4108 +/- ##
===========================================
+ Coverage 65.90% 89.38% +23.48%
===========================================
Files 158 59 -99
Lines 21000 7087 -13913
Branches 1239 0 -1239
===========================================
- Hits 13839 6335 -7504
+ Misses 6748 752 -5996
+ Partials 413 0 -413
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
jp-dark
approved these changes
Jun 10, 2025
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 10, 2025
…ions to Experiment (#4108) * skip obs axis read-back when appending known unique observations to Experiment * add change log entry
jp-dark
added a commit
that referenced
this pull request
Jun 11, 2025
…ions to Experiment (#4108) (#4116) * skip obs axis read-back when appending known unique observations to Experiment * add change log entry Co-authored-by: Bruce Martin <[email protected]> Co-authored-by: Julia Dark <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context:
Ingest (
from_anndata/from_h5ad) will filter duplicate obs and var IDs as part of appending new data. In the case where the obs axis is a priori known to contain only unique IDs, this filter step can be bypassed, for a performance win. This builds upon the previous change toregister_{anndatas,h5ads}which introduced theallow_duplicate_obs_idsparameter.Fixes SOMA-259