[python] do not attempt to resize empty measurements in tiledbsoma.io.prepare_experiment#4103
Merged
bkmartinjr merged 6 commits intomainfrom Jun 3, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4103 +/- ##
===========================================
+ Coverage 66.11% 89.35% +23.24%
===========================================
Files 158 59 -99
Lines 21110 7066 -14044
Branches 1238 0 -1238
===========================================
- Hits 13956 6314 -7642
+ Misses 6741 752 -5989
+ Partials 413 0 -413
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
jp-dark
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context:
If an experiment has empty Measurements (i.e., var axis is empty dataframe), prepare_experiment will fail. It should just ignore these empty dataframes as they do not need resizing.
Fixes SOMA-184
Changes:
Add code to ignore empty var dataframes.