[python] treat timestamp of zero as equivalent to None#4071
Merged
bkmartinjr merged 4 commits intomainfrom May 21, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4071 +/- ##
===========================================
+ Coverage 65.28% 89.27% +23.99%
===========================================
Files 160 59 -101
Lines 21323 7078 -14245
Branches 1259 0 -1259
===========================================
- Hits 13920 6319 -7601
+ Misses 6992 759 -6233
+ Partials 411 0 -411
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
jp-dark
approved these changes
May 21, 2025
Collaborator
jp-dark
left a comment
jp-dark
left a comment
There was a problem hiding this comment.
The change here looks good, but we should also update our docstrings to call out this oddity around timestamp=0. If it doesn't go in this PR can you add an issue for that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context:
Fixes SOMA-72
A timestamp value of zero is not a legal timestamp in TileDB. TileDB APIs treat
Noneand0as equivalent to the default time ofnow. As of TileDB-SOMA 1.15 this package regressed and treated zero as a specific time, which will raise inscrutable errors in various code paths.Changes:
A timestamp value of zero (int) or epoch (datetime.datetime) is equivalent to
now.