[r] Add check_only support for domain/shape updates#3400
Merged
Conversation
johnkerl
force-pushed
the
kerl/check-only-r
branch
from
4b4c223 to
5d4893d
Compare
mojaveazure
requested changes
Dec 5, 2024
johnkerl
force-pushed
the
kerl/check-only-r
branch
from
a353014 to
b1e7ebd
Compare
Contributor
Author
|
@mojaveazure thanks for the great feedback -- ready for round two! |
mojaveazure
approved these changes
Dec 5, 2024
Member
mojaveazure
left a comment
mojaveazure
left a comment
There was a problem hiding this comment.
I missed two places where we should be checking if (isTRUE(check_only)) 🤦, added as suggestions but otherwise this LGTM. Assuming CI passes, please remember to update the changelong, bump the develop version, and 🚢
Co-authored-by: Paul Hoffman <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
These parallel logic surfaced on the Python side but not on the R side.
Found while working on https://cloud.tiledb.com/academy/structure/life-sciences/single-cell/tutorials/shapes/
Notes for Reviewer:
There is unit-test coverage. Also, I ran the cells in https://github.com/TileDB-Inc/TileDB-Documentation/pull/454.