[python/r] Update docstrings for domain argument to create#3396
Merged
[python/r] Update docstrings for domain argument to create#3396
domain argument to create#3396Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3396 +/- ##
==========================================
+ Coverage 85.85% 85.94% +0.09%
==========================================
Files 55 55
Lines 6199 6199
==========================================
+ Hits 5322 5328 +6
+ Misses 877 871 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mojaveazure
requested changes
Dec 3, 2024
johnkerl
force-pushed
the
kerl/domain-at-create-docstrings
branch
from
0a89bb6 to
9361992
Compare
mojaveazure
approved these changes
Dec 3, 2024
Member
mojaveazure
left a comment
mojaveazure
left a comment
There was a problem hiding this comment.
LGTM on the R side, please remember to update the docs with devtools::document()
Contributor
Author
|
@ryan-williams I'd love a second pair of 👀 for the Python side -- if you haven't time, that's fine, I'll need to merge by say mid-day tomorrow |
Contributor
ryan-williams
left a comment
ryan-williams
left a comment
There was a problem hiding this comment.
Couple questions about the Python docstr
ryan-williams
approved these changes
Dec 4, 2024
Contributor
Author
|
#3398 tracks the CI break which was not caused by this docstring-only PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.