Conversation
johnkerl
changed the title
use_current_domain teardownuse_current_domain unit-test/feature-flag teardown
johnkerl
changed the title
use_current_domain unit-test/feature-flag teardownuse_current_domain unit-test/feature-flag teardown, part 1/n
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## kerl/227a #3369 +/- ##
==========================================
Coverage 86.15% 86.15%
==========================================
Files 55 55
Lines 6094 6094
==========================================
Hits 5250 5250
Misses 844 844
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This was referenced Nov 22, 2024
johnkerl
changed the title
use_current_domain unit-test/feature-flag teardown, part 1/nuse_current_domain unit-test/feature-flag teardown, part 1 of 4
XanthosXanthopoulos
approved these changes
Nov 22, 2024
johnkerl
added a commit
that referenced
this pull request
Nov 22, 2024
* [python/r] Remove 2.27-related feature flag * more * [c++] Some `use_current_domain` unit-test/feature-flag teardown, part 1 of 4 (#3369) * [c++] Some `use_current_domain` teardown * lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048]. Also #3273.
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
The
use_current_domainlogic was solely transitional while awaiting core 2.27.0rc3, which we now have in place. It's time to dismantle this code which is now needlessly complicating our unit-test framework.Notes for Reviewer:
This is first in a series of PRs. While the changes are trivial, the line-count can be intimidating when it's attempted all at once.
Stacked on #3368