Conversation
This was referenced Nov 20, 2024
johnkerl
force-pushed
the
kerl/revert-3300
branch
from
4027b86 to
e978c4d
Compare
johnkerl
force-pushed
the
kerl/revert-3300
branch
from
e978c4d to
1cf14ec
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3358 +/- ##
==========================================
+ Coverage 85.65% 85.74% +0.09%
==========================================
Files 57 57
Lines 6203 6201 -2
==========================================
+ Hits 5313 5317 +4
+ Misses 890 884 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bkmartinjr
approved these changes
Nov 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048]. Reverts #3300.
Changes: Per @bkmartinjr
Notes for reviewer: