Conversation
johnkerl
force-pushed
the
kerl/r-data-refresh
branch
2 times, most recently
from
4adb36e to
73a6858
Compare
johnkerl
force-pushed
the
kerl/r-data-refresh
branch
from
73a6858 to
d52e2fe
Compare
johnkerl
changed the title
johnkerl
force-pushed
the
kerl/r-data-refresh
branch
from
ad15833 to
8130dc4
Compare
mojaveazure
requested changes
Nov 7, 2024
Member
mojaveazure
left a comment
mojaveazure
left a comment
There was a problem hiding this comment.
So it seems the original pbmc3k-processed-obs was from Scanpy, not Seurat (based on the column name changes in test-SOMAArrayReader-Arrow.R and test-SOMADataFrame.R; I've got one comment about a missing README entry
mojaveazure
approved these changes
Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
inst/extdatadirectory to have new-style shapes -- primarily for the benefit of vignettes on [r] Vignette for new-shape feature #3302.README.mdfor the benefit of future maintainersNotes for Reviewer: