Merged
Conversation
johnkerl
force-pushed
the
kerl/new-shape-vignette
branch
3 times, most recently
from
6aff832 to
e7e0133
Compare
This was referenced Nov 7, 2024
johnkerl
force-pushed
the
kerl/new-shape-vignette
branch
2 times, most recently
from
5d38375 to
91ec81d
Compare
johnkerl
force-pushed
the
kerl/new-shape-vignette
branch
2 times, most recently
from
3adfcf6 to
d4ffe39
Compare
johnkerl
changed the title
johnkerl
force-pushed
the
kerl/new-shape-vignette
branch
from
77a8213 to
aa39bfc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3302 +/- ##
==========================================
+ Coverage 85.09% 85.27% +0.17%
==========================================
Files 53 53
Lines 5577 5574 -3
==========================================
+ Hits 4746 4753 +7
+ Misses 831 821 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
force-pushed
the
kerl/new-shape-vignette
branch
from
6c45b74 to
3c4bb1d
Compare
mojaveazure
approved these changes
Dec 2, 2024
johnkerl
force-pushed
the
kerl/new-shape-vignette
branch
from
3c4bb1d to
c3cf16f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
This is the R counterpart to #3294.
Notes for Reviewer:
There will be Academy material as well, in a separate PR.