[python/r] Move beyond the new-shape feature flag#3301
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3301 +/- ##
==========================================
+ Coverage 85.29% 85.48% +0.18%
==========================================
Files 52 52
Lines 5517 5499 -18
==========================================
- Hits 4706 4701 -5
+ Misses 811 798 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
changed the title
nguyenv
approved these changes
Nov 7, 2024
mojaveazure
approved these changes
Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
These have been on by default for several weeks now. It's time to keep them.
Note there is another bit of logic (same files) around whether dense arrays can have current domain, which can't be removed until core 2.27 is released, and we move our core dependency to 2.27.
Notes for Reviewer:
This is less ambitious than #3259, which needs to wait until core 2.27.