[python] Tutorial notebook for the new-shape feature#3294
Merged
Conversation
johnkerl
force-pushed
the
kerl/new-shape-notebook-and-vignette
branch
from
8d2c7e4 to
89a5238
Compare
aaronwolen
approved these changes
Nov 5, 2024
Contributor
Author
|
Converting to draft while I do some underwork as I noted above when I said
|
johnkerl
force-pushed
the
kerl/notebook-new-shape-refresh
branch
4 times, most recently
from
bd5ab54 to
20d4831
Compare
johnkerl
force-pushed
the
kerl/new-shape-notebook-and-vignette
branch
2 times, most recently
from
b7078be to
50210b9
Compare
johnkerl
force-pushed
the
kerl/notebook-new-shape-refresh
branch
from
20d4831 to
23953ae
Compare
johnkerl
force-pushed
the
kerl/new-shape-notebook-and-vignette
branch
from
50210b9 to
ceba815
Compare
johnkerl
force-pushed
the
kerl/new-shape-notebook-and-vignette
branch
from
ceba815 to
017ea32
Compare
johnkerl
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3294 +/- ##
==========================================
+ Coverage 85.29% 85.40% +0.10%
==========================================
Files 52 52
Lines 5517 5517
==========================================
+ Hits 4706 4712 +6
+ Misses 811 805 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nguyenv
approved these changes
Nov 7, 2024
Co-authored-by: nguyenv <[email protected]>
Co-authored-by: nguyenv <[email protected]>
Co-authored-by: nguyenv <[email protected]>
Co-authored-by: nguyenv <[email protected]>
Contributor
Author
|
Merging this round of changes ... @aaronwolen let me know if you have any post-merge feedback and I'm happy to take a follow-on. Also I'll send the corresponding Academy PRs your way 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
Notebook material for Python. (R material will be a separate PR.)
Notes for Reviewer:
The Python material is ready for review.
Handy link for reviewers:
I'm working on the R material.