[python] Re-run, and update, example notebooks with new shape feature#3290
Merged
[python] Re-run, and update, example notebooks with new shape feature#3290
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3290 +/- ##
==========================================
+ Coverage 85.29% 85.40% +0.10%
==========================================
Files 52 52
Lines 5517 5517
==========================================
+ Hits 4706 4712 +6
+ Misses 811 805 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
force-pushed
the
kerl/notebook-new-shape-refresh
branch
from
58b711c to
01473ca
Compare
This was referenced Nov 4, 2024
johnkerl
changed the title
nguyenv
approved these changes
Nov 4, 2024
johnkerl
force-pushed
the
kerl/dataframe-shape-temp
branch
from
2ab86e1 to
086cf3e
Compare
johnkerl
force-pushed
the
kerl/notebook-new-shape-refresh
branch
from
01473ca to
71668ec
Compare
johnkerl
force-pushed
the
kerl/dataframe-shape-temp
branch
from
086cf3e to
a592f3a
Compare
johnkerl
force-pushed
the
kerl/notebook-new-shape-refresh
branch
from
71668ec to
c37833b
Compare
Contributor
Author
|
Converting to draft while I rework the data storage on a separate PR |
johnkerl
force-pushed
the
kerl/notebook-new-shape-refresh
branch
3 times, most recently
from
5f5d2a7 to
bd5ab54
Compare
Contributor
Author
|
@aaronwolen re-requesting review as this is now rebased on top of #3295 (which has been merged). |
johnkerl
force-pushed
the
kerl/notebook-new-shape-refresh
branch
from
bd5ab54 to
20d4831
Compare
* Geometry dataframe implementation, use spatial axes when available when creating schema * Address PR review comments
johnkerl
force-pushed
the
kerl/notebook-new-shape-refresh
branch
from
20d4831 to
23953ae
Compare
aaronwolen
approved these changes
Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
Re-execute our notebooks with the new-shape feature. Change the wording in many places to remove needless complexities from the pre-shape era.
This PR affects existing notebooks. There is a separate PR with a new notebook dedicated to the new shape feature: #3294.
Notes for Reviewer:
This PR was run on a system with core
dev(2.27-to-be) installed on it.Handy review link with rendered notebooks:
https://github.com/single-cell-data/TileDB-SOMA/tree/kerl/notebook-new-shape-refresh/apis/python/notebooks