[python] Run upgrade-shapes on notebook example experiments#3289
Merged
[python] Run upgrade-shapes on notebook example experiments#3289
Conversation
This was referenced Nov 4, 2024
nguyenv
approved these changes
Nov 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
Run
tiledbsoma.io.upgrade_experiment_shapeson the notebook example experiments.Notes for Reviewer:
PRs for notebook content are soon to come, to be stacked on top of this.
Stacking as of today:
maintiledbsoma_upgrade_shapeforDenseNDArray#3288shapeaccessor forDataFrame[RFC] #3276, inserted here as a simplifying prerequisite as noted aboveThe following was run on a system with core
dev(soon to be 2.27) on it, wherein we have support for new shape on dense arrays.Shapes before:
Details
The upgrade:
Shapes after:
Details