[python] Include tiledbsoma_upgrade_shape for DenseNDArray#3288
Merged
[python] Include tiledbsoma_upgrade_shape for DenseNDArray#3288
tiledbsoma_upgrade_shape for DenseNDArray#3288Conversation
johnkerl
force-pushed
the
kerl/dense-ugrsh
branch
from
3a397c5 to
86752ec
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3288 +/- ##
==========================================
- Coverage 83.67% 83.61% -0.07%
==========================================
Files 51 51
Lines 5556 5571 +15
==========================================
+ Hits 4649 4658 +9
- Misses 907 913 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This was referenced Nov 4, 2024
jp-dark
approved these changes
Nov 4, 2024
Contributor
Author
|
Thanks @jp-dark ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
This was an omission on the 2.27 work.
Notes for Reviewer:
PR stacking as of today:
maintiledbsoma_upgrade_shapeforDenseNDArray#3288shapeaccessor forDataFrame[RFC] #3276, inserted here as a simplifying prerequisite as noted above