Conversation
This was referenced Oct 31, 2024
mojaveazure
approved these changes
Nov 1, 2024
Member
mojaveazure
left a comment
mojaveazure
left a comment
There was a problem hiding this comment.
One suggestion to produce more informative test failure messages, but otherwise LGTM
Co-authored-by: Paul Hoffman <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048]. See also #3364.
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
Fixes for testing with core 2.27 (which is not released yet). See also TileDB-Inc/centralized-tiledb-nightlies#25.
Notes for Reviewer: