[python] Fix last 2.27+Python+dense failing test case#3269
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3269 +/- ##
==========================================
+ Coverage 83.81% 83.92% +0.11%
==========================================
Files 51 51
Lines 5578 5580 +2
==========================================
+ Hits 4675 4683 +8
+ Misses 903 897 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This was referenced Nov 1, 2024
nguyenv
approved these changes
Nov 1, 2024
Contributor
Author
|
Thanks @nguyenv !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048]. See also #3364.
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
Following on #3263 and #3268 which deal with issues with core 2.27 and dense arrays. See also TileDB-Inc/centralized-tiledb-nightlies#25.
There is more work to be done for R tests at 2.27 (#3270) but this resolves the final issue with the Python side.
There is a TODO marked in the code on this PR: there are other cases which would have failed even at 2.26 and below, had they been written. This is addressed on #3271.
Notes for Reviewer: