[python] Fix some dense+2.27 failing test cases#3265
Merged
Conversation
This was referenced Oct 30, 2024
nguyenv
approved these changes
Oct 30, 2024
| coords = NULL, | ||
| result_order = "auto", | ||
| log_level = "warn" | ||
| log_level = "auto" |
Contributor
There was a problem hiding this comment.
Was this meant to be included in this PR?
Contributor
Author
There was a problem hiding this comment.
Yes it was -- I should have commented. It actually overrides the environment variable SPDLOG_LEVEL and makes requested log statements NOT appear :(. This has already been fixed for other classes except this one. I thought this was a nice little thing to include in this 'misc. bits' PR.
Sorry for the lack of clarity!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3265 +/- ##
==========================================
+ Coverage 83.80% 83.90% +0.10%
==========================================
Files 51 51
Lines 5563 5567 +4
==========================================
+ Hits 4662 4671 +9
+ Misses 901 896 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048]. See also #3364.
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
We've had current-domain support since core 2.26 for core sparse arrays: soma
DataFrameandSparseNDArray. We don't have it forDenseNDArrayuntil core 2.27, which isn't released yet.This is tested using @jdblischak 's nightlies as tracked here: TileDB-Inc/centralized-tiledb-nightlies#25. It can also be tested by doing a from-source core install on a laptop -- which is what I do on one of my laptops.
There are some larger issues to be fixed, which I've done piecemeal on to-be-abandoned #3244. There is also a single large issue to be fixed on #3263. Meanwhile, this PR fixes a few one-off issues.
Notes for Reviewer: