[python] Rename set_reader_coords to set_coords#3253
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3253 +/- ##
==========================================
+ Coverage 83.79% 83.90% +0.10%
==========================================
Files 51 51
Lines 5560 5560
==========================================
+ Hits 4659 4665 +6
+ Misses 901 895 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
added a commit
that referenced
this pull request
Oct 29, 2024
Co-authored-by: John Kerl <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
@nguyenv mentioned the other doing this. However while working on #3244 I realized it was a good deconfuse for me to go ahead and do this sooner than later.
Notes for Reviewer: