Skip to content

[python] Fix bad merge of #3236#3241

Merged
johnkerl merged 1 commit intomainfrom
kerl/fix-bad-merge
Oct 25, 2024
Merged

[python] Fix bad merge of #3236#3241
johnkerl merged 1 commit intomainfrom
kerl/fix-bad-merge

Conversation

@johnkerl
Copy link
Copy Markdown
Contributor

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Changes:

#3236 had green CI pre-merge, red CI post-merge. Fix this.

Notes for Reviewer:

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.99%. Comparing base (87975b4) to head (1e5fdb4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3241      +/-   ##
==========================================
+ Coverage   83.86%   83.99%   +0.12%     
==========================================
  Files          51       51              
  Lines        5505     5512       +7     
==========================================
+ Hits         4617     4630      +13     
+ Misses        888      882       -6     
Flag Coverage Δ
python 83.99% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 83.99% <92.00%> (+0.12%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl requested review from jp-dark and nguyenv October 25, 2024 16:56
@johnkerl johnkerl merged commit d7e6ff8 into main Oct 25, 2024
@johnkerl johnkerl deleted the kerl/fix-bad-merge branch October 25, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants