[r] Proper prefixing for shape-related methods#3237
Merged
Conversation
johnkerl
changed the title
johnkerl
force-pushed
the
kerl/py-r-ugr-dom-2
branch
from
b540d3f to
05740b7
Compare
johnkerl
force-pushed
the
kerl/py-r-ugr-dom
branch
from
c1bbb6e to
fe534fd
Compare
johnkerl
force-pushed
the
kerl/py-r-ugr-dom-2
branch
from
05740b7 to
5b4695e
Compare
johnkerl
force-pushed
the
kerl/py-r-ugr-dom
branch
2 times, most recently
from
2ad8a5a to
b843e48
Compare
johnkerl
force-pushed
the
kerl/py-r-ugr-dom-2
branch
from
5b4695e to
4feecff
Compare
johnkerl
force-pushed
the
kerl/py-r-ugr-dom
branch
from
95182e3 to
a59204c
Compare
johnkerl
force-pushed
the
kerl/py-r-ugr-dom-2
branch
from
4feecff to
5bfb69e
Compare
mojaveazure
requested changes
Oct 28, 2024
johnkerl
force-pushed
the
kerl/py-r-ugr-dom
branch
from
a59204c to
b28d022
Compare
johnkerl
force-pushed
the
kerl/py-r-ugr-dom-2
branch
from
5bfb69e to
b84a478
Compare
mojaveazure
requested changes
Oct 28, 2024
johnkerl
force-pushed
the
kerl/py-r-ugr-dom-2
branch
from
b84a478 to
178eae6
Compare
johnkerl
force-pushed
the
kerl/py-r-ugr-dom-2
branch
from
178eae6 to
8f64cf1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3237 +/- ##
=======================================
Coverage ? 83.94%
=======================================
Files ? 51
Lines ? 5557
Branches ? 0
=======================================
Hits ? 4665
Misses ? 892
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mojaveazure
approved these changes
Oct 28, 2024
Member
mojaveazure
left a comment
mojaveazure
left a comment
There was a problem hiding this comment.
Please bump the develop version, update the changelog, and then 🚢
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
Direct R analogue of #3236
Notes for Reviewer: